Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localized Heroku deployment guide #762

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

shaydewael
Copy link
Contributor

Summary

This PR adds a Japanese version of the Heroku deployment guide. A live preview can be found at https://shaydewael.github.io/bolt-js/ja-jp/deployments/heroku

I also removed redirects from deployment guides because I'm not sure it makes sense, and there were duplicative redirects.

Requirements (place an x in each [ ])

@shaydewael shaydewael requested a review from seratch January 20, 2021 18:26
@gitwave gitwave bot added the untriaged label Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #762 (6f640aa) into main (35aef1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files          11       11           
  Lines        1086     1086           
  Branches      320      320           
=======================================
  Hits          706      706           
  Misses        321      321           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35aef1a...6f640aa. Read the comment docs.

@mwbrooks mwbrooks added docs M-T: Documentation work only and removed untriaged labels Jan 20, 2021
@seratch
Copy link
Member

seratch commented Jan 20, 2021

Thanks - LGTM 👍

@seratch seratch merged commit 09e6728 into slackapi:main Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants